Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge]check new python syntax #60279

Closed
wants to merge 2 commits into from

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Dec 22, 2023

PR types

Others

PR changes

Others

Description

关于 #59874 (comment) 的一个简单实现

为什么暂时在 sot 测试 ?

  • sot 与 python 版本几乎强绑定,且 ci-sot 是目前 python 版本最全的 ci

为什么没有用 pre-commit ?

  • 不是所有开发者本地都有那么多 python 环境,增加 pre-commit 只能检查开发环境,这是无意义的

为什么测试了所有支持的 python 版本?

  • 防止 python 语法向下不兼容(虽然目前为止还没有)

最终形态请不要部署在PR-CI-SOT ❕, 请不要部署在PR-CI-SOT ❕, 请不要部署在PR-CI-SOT ❕

Copy link

paddle-bot bot commented Dec 22, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 22, 2023
@gouzil gouzil requested review from zrr1999 and removed request for zrr1999 December 22, 2023 13:18
@gouzil
Copy link
Member Author

gouzil commented Dec 22, 2023

@gouzil gouzil closed this Dec 22, 2023
@gouzil gouzil deleted the check_new_python_syntax branch April 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants